Hi all,
A new alpha release is available. Please see the change notes for more info: Changes in 2.1.45 - Anki Betas
Hi all,
A new alpha release is available. Please see the change notes for more info: Changes in 2.1.45 - Anki Betas
Reading that changelog made me feel like christmas came super early this year Thanks for your hard work @dae, @hengiesel, @Rumo and everyone else!
I wonât go into all the add-ons that break with this update (most have to do with a change/removal of NoteType
), since youâll probably publish a porting guide soon.
The following issues occur with all add-ons manually disabled. I will expand the list if I stumble upon other irregularities:
General
Browser issue, probably due to add-on
I think I know where this error stems from. I had used the Advanced Browser add-on and forgot to remove an extra column (Flag) before updating to 2.1.45. It left a remnant column called âAdd-onâ.
Update: I reinstalled 2.1.44, disabled the extra column of Advanced Browser and reinstalled 2.1.45. The extra column was still there. After removing that âAdd-onâ-column via the GUI (as suggested by Rumo below), Anki doesnât crash anymore, but it throws the following exception when switching between the two views:
Caught exception:
Traceback (most recent call last):
File "aqt\browser\table\table.py", line 362, in _on_sort_column_changed
File "aqt\browser\table\model.py", line 225, in column_at_section
File "aqt\browser\table\state.py", line 40, in column_key_at
IndexError: list index out of range
I can confirm this.
This is very likely the cause, but it shouldnât happen, and in fact, I thought this exact bug had been fixed. Iâll see what I can do.
By the way, you should be able to disable âAdd-onâ columns from the GUI now.
The new toolbar looks awesome. Iâve noticed, however, that the buttons added by add-ons look quite different from those that are built-in.
I tried to tweak a little the css and I got this:
which, IMHO, gives the toolbar a more consistent look.
Just my guess: I believe if the add-on devs use the new toolbar API to add their buttons, they will look just like the default ones. The ugly look (hopefully) only applies to buttons which are added in the legacy-way, which is kept for compatibility reasons.
However, I really like your CSS tweak and even if itâs just for this short transition phase, it would be nice if it were integrated.
Ah, I see. Thanks for the explanation.
Thanks for this awesome update!
About the previous comments
on windows 10 the âsafe modeâ on anki donât appear to be disabling all the add-ons and is working like a normal mode
About theâŚ
Donât take theses ideas with seriousness they are only personal preference
The next alpha will add an alias for NoteType. Feel free to post other add-on errors you get (perhaps in a different thread) - many may be unavoidable due to how much has been changed, but sometimes breakages are unintentional and easy to fix.
@Ab_Bc if those styling changes donât cause a regression for other add-ons, please feel free to send through a PR
Left-aligning the single-row items makes them feel a bit unbalanced, but maybe we could do that for the learning steps when they take up a whole line? Anyone else want to chime in?
I donât know exactly how to work with PRs, but since the changes I made are very simple I think I can list them here:
In .linkb
I added:
background-color: white; border: 1px solid var(--medium-border);
And in .topbut
I added:
position: relative; bottom: 2.7px;
In order to keep this compatible with night mode, we might have to introduce a new CSS variable for the button background color and border color OR use an existing class that already imitates the Svelte buttons.
I suggest the following:
:root[class*=night-mode] {
...
--button-bg: #666;
--button-border: #666;
}
:root {
...
--button-bg: white;
--button-border: var(--medium-border);
}
You can find the variable definitions here: anki/ts/sass/_vars.scss at 5449198649c623fa65ae8d184925ef9c6aae5a71 ¡ ankitects/anki ¡ GitHub
Right. And in addition the changes I posted make the buttons have always the same look even when the user hovers on or click on them, so (in light mode) something like
.linkb:hover { background-color: #ebebeb; }
should be added.
Thanks a lot for such an awesome update, the new features are terrific!
Unfortunately, Closet for Anki, / Asset Manager / Anki Persistence, all three esential to me, seems to be not working properly with the update:
An add-on you installed failed to load. If problems persist, please go to the Tools>Add-ons menu, and disable or delete the add-on.
When loading ââ¨Closet For AnkiâŠâ:
â¨Traceback (most recent call last):
File âaqt\addons.pyâ, line 217, in loadAddons
File âC:\Users\sergi\AppData\Roaming\Anki2\addons21\272311064_init_.pyâ, line 1, in
from .src import init
File âC:\Users\x\AppData\Roaming\Anki2\addons21\272311064\src_init_.pyâ, line 3, in
from .hook import setup_script, install_script
File âC:\Users\sergi\AppData\Roaming\Anki2\addons21\272311064\src\hook.pyâ, line 25, in
if am := find_addon_by_name(âAsset Managerâ):
File âC:\Users\x\AppData\Roaming\Anki2\addons21\272311064\src\utils.pyâ, line 19, in find_addon_by_name
return import_module(name)
File âimportlib_init_.pyâ, line 127, in import_module
File âC:\Users\x\AppData\Roaming\Anki2\addons21\656021484_init_.pyâ, line 10, in
from .src import setup
File âC:\Users\sergi\AppData\Roaming\Anki2\addons21\656021484\src_init_.pyâ, line 1, in
from .webview import init_webview
File âC:\Users\x\AppData\Roaming\Anki2\addons21\656021484\src\webview_init_.pyâ, line 7, in
from âŚconfig import maybe_get_setting_from_card
File âC:\Users\x\AppData\Roaming\Anki2\addons21\656021484\src\config.pyâ, line 7, in
from anki.models import NoteType
ImportError: cannot import name âNoteTypeâ from âanki.modelsâ (C:\Program Files\Anki\anki\models.pyc)
âŠ
On the other hand, on a purely aesthetic note, the font size used in the new deck option window, maybe look too large compared to other elements of the GUI, specially for those of using the user interface size option with a value larger than 100.
I think most of those will be fixed with this change:
Completely agree, all elements seem a bit too big. Also, having all options on one page is a bit overwhelming. Maybe tabs (like in previous versions) would help here. I would prefer not having to scroll to get to the desired option.
It looks much better in Damienâs screenshot, so I assume the following issues are Windows-specific:
@NameLessGO, I think it looks odd because the window is extremely wide in your screenshot.
Another minor point: The counters seem to use the system language rather than the Anki setting. I.e., I see decimal commas even though my Anki is set to English.
On my Linux system, the options container seems to have a max-width but almost no margin when you minimize the windowâs width:
The single-page layout could make it easier to share deck options via screenshots, but only if the options fit onto the vertical screen-space. As you can see on my screenshot, even with a maximized window at 1920x1080, only half of the content is visible.
Iâm getting an error message when clicking in the new âToggle Showing Card / Notesâ icon on the browser:
Debug info:
Anki 2.1.45 (10bfb95f) Python 3.8.6 Qt 5.14.2 PyQt 5.14.2
Platform: Windows 10
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2021-05-17 13:47:56
Caught exception:
Traceback (most recent call last):
File âaqt\browser\table\table.pyâ, line 362, in _on_sort_column_changed
File âaqt\browser\table\model.pyâ, line 225, in column_at_section
File âaqt\browser\table\state.pyâ, line 40, in column_key_at
IndexError: list index out of range
I also got this problem after a few uses of the new alpha version:
Iâve never had this problem before. Just restarting the computer solved it
Most likely the same bug as reported by @kleinerpirat. Iâm positive that itâs fixed on the main branch.
As a reference, this is how I hacked my buttons for night mode:
.linkb {
...
background-color: #666;
border-style: none;
margin-left: 1px;
padding-bottom: 2.7px;
}
.topbut {
...
filter: invert(1);
}
Just wanted to add my thoughts in at the moment. Loving all the new updates and Iâm excited to try the new scheduler once I can get things working
It broke ~15 add-ons for me. Iâll get an updated list on here once I have time to figure out exactly which ones
Personally I donât love the look of the new settings. I think the settings are already not super user friendly but the new look is worse. Having things organized by tabs was much simpler. Thereâs too much space between text and input box with the new look. Iâd strongly favor reverting to the old look unless thereâs an overwhelming majority that prefer the new one.
Vertical, mobile friendly design, which makes little sense in the widescreen era⌠Factoring this, im not loving the new design
This is the reason this add-on (browser side-by-side) and similars should be default in desktop anki
The new design does look more modern and neat. And i have no idea how would you use horizontal space to make it look as good as the new proposalđ¤ˇââď¸