By “version” I don’t mean FSRS-4.5 or FSRS-5, I mean this: Releases · open-spaced-repetition/fsrs-rs · GitHub
It could be useful for troubleshooting. Also, maybe display it here:
4 Likes
You can already get the FSRS commit from the Anki commit.
$ git show 201f1394:Cargo.toml | grep fsrs -A1
[workspace.dependencies.fsrs]
version = “1.2.2”
Yeah, but it would be more convenient if it was directly in the debug info
This is what David is planning. You two should probably talk to ensure that you see eye to eye on this.
1 Like
For context/linkage, my thoughts are here:
After a discussion with Voczi, Jarrett Ye & Expertium, there’s consensus for displaying the library version.
I personally disagree here (I believe displaying the user-facing version is better), but it’s a quick change to make to improve things if necessary
The FSRS devs will feel the support burden from this change more than AnkiDroid, and it’s only fair to them to help them with user support as much as possible
2 Likes
IMO, adding the FSRS version to the about page or Debug info doesn’t add much value because just knowing the Anki version tells us what FSRS changes were included.
Also, some FSRS changes involve changes to the Anki’s code, but not the FSRS-rs code. So, if two Anki releases have the same FSRS-rs version but slightly different behaviors, then the users might get confused.
For example, consider the bug fix in the following commit.
Suppose that this bug fix was made after the stable release of 24.10 in a patch release (like 24.10.1). Then, some users may get confused why the scheduling is different despite the same FSRS version.
[In the same PR, LMSherlock has also bumped the FSRS version, but that’s for an unrelated change. So, please ignore that.]
2 Likes
You can see all changes introduced by any version of FSRS-rs:
1 Like
I don’t think adding it to the about screen / debug info adds much utility, and it has the potential to cause more confusion - especially if you choose to show the library version. As @vaibhav has pointed out, the behaviour a user sees is a product of not only the FSRS crate but Anki’s integration of it as well, so having the FSRS version match in two clients is not a guarantee that things will be the same, or that there will be problems if it is different. I think it’s simpler and more useful to tell users on Anki X that they should use mobile version Y or greater or vice versa.
2 Likes