Change the "parameters appear to be optimal" message when there are 0 reviews

Anki FSRS
1

https://www.reddit.com/r/Anki/comments/1h6lyi6/what_this_popup_say/

sigh
it’s that time of the year again, the “WOULD SOMEBODY PLEASE CHANGE THE MESSAGE IF THERE ARE 0 REVIEWS” time.

This user uses 24.11, so it’s not just a bug (that was fixed in 24.11).

@dae @L.M.Sherlock for the 82148086513282306647 time, CAN WE PLEASE CHANGE THE MESSAGE IF THE NUMBER OF REVIEWS IS 0?!

I AM REALLY TIRED OF MAKING THE SAME GOD DAMN SUGGESTION OVER AND OVER

Seriously, it can’t be that hard, right? Just display a different text if there are 0 reviews. That’s all. Problem solved. Why is this not a thing a year after FSRS has been implemented?

I get that I have been annoying about the Hard button misuse and automatic optimization. But at least those two have legitimate reasons why they cannot be solved with a simple 2-5 lines fix that takes 5 minutes to code. This one doesn’t.

1 Like
2

It says right there this guy has 0 reviews though, why do we need things complicated

1 Like
3

Because “parameters appear optimal” doesn’t make sense if there is no review history to optimize/evaluate the parameters on. And a lot of users will never suspect that something is wrong.

1 Like
4

And a lot of users will never suspect that something is wrong.

Let them be :blush:

(I mean, it’s not a huge issue anyway. FSRS still works fire.)

5

Even in the comments to the post you can see that one of the commenters didn’t realize that OP has 0 reviews. OP himself didn’t realize it either.

Can we please not discuss whether this obviously good change is good and just Actually Do It? I wish there we had, like, The Official Doer Of Things The Need To Be Done (not Dae, he’s too busy) for cases like this.

It’s such a simple change that will make troubleshooting easier, yet here we are.

6

If someone wanted to do this they would’ve done it already so what can we even do now.

1 Like
7

I don’t know how to implement this (I only know a little bit of C) but if I understand the code correctly the following would have to be changed:

if (
	(params.length &&
		params.every(
			(n, i) => n.toFixed(4) === resp.params[i].toFixed(4),
		)) ||
	resp.params.length === 0
) {
	setTimeout(() => alert(tr.deckConfigFsrsParamsOptimal()), 200);
} else {
	$config.fsrsParams5 = resp.params;
}

(see anki/ts/routes/deck-options/FsrsOptions.svelte at f6a3e98ac3dcb19d54e7fdbba96bf2fa15fc2b3f · ankitects/anki · GitHub)

The message comes from alert(tr.deckConfigFsrsParamsOptimal()), 200); which corresponds to this:

deck-config-fsrs-params-optimal = The FSRS parameters currently appear to be optimal.

(see anki/ftl/core/deck-config.ftl at f6a3e98ac3dcb19d54e7fdbba96bf2fa15fc2b3f · ankitects/anki · GitHub)

1 Like
8

PR

This was suspiciously easy to fix. I guess it’s intentional. Default parameters are “techincally” the optimal for an empty deck after all.

The options now there if they do agree to it though.

3 Likes
9

Great work!:+1:

10

It’s my first time hearing about this.

1 Like
13

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.