The FSRS Simulator graph & tooltips are wrong

rossgb · December 16, 2024, 7:09pm

1. The number of reviews in the tooltips seem to be off by one day

The easiest way to see this is by mousing over a peak, looking at the number of reviews, then move one to the right. The number will go up instead of down.

2. The number of reviews tomorrow is sometimes significantly less than it should be.

N.B. I’m deliberately looking at “in 2 days” to account for the first issue.

e.g.:

Interestingly the number is correct if you simulate 30 days:

sorata · December 16, 2024, 7:22pm

I have also seen a very stark mismatch between what the graph shows and what the tooltip shows (which might be related to #1 in OP).

A simulation for 3 days:

Look at the y-axis and it should be 30 cards for tomorrow but the tooltip shows 6 cards. The number for two days later is 30 cards which seems correct.

My educated guess is it’s showing me the number of learning cards I’ve left for today.

sorata · December 16, 2024, 8:22pm

Steps

Run a simulation using the defualt values.
Run a simulation for 3650 days.
Click on a part of the graph after the point where 1^st simulation ended.

Behaviour

The tooltip shows you number of reviews for both of the simulation but as the first simulation ended at an earlier day it should show nothing. Currently it gets the data for the last simulated day instead and shows it to the user.

Expertium · December 16, 2024, 8:40pm

Already mentioned here: The FSRS Simulator graph & tooltips are wrong

sorata · December 16, 2024, 8:44pm

I was talking about this:

The first simulation ends at 30 days. After 53 days, there should be nothing to show me from the 1^st simulation.

rossgb · December 16, 2024, 8:46pm

It’s a different issue from the two I mentioned before.

Poor Jarrett, it feels like we are dogpiling on him with all these issues now.

That’s why I was orignally not mentioning it while it said “(experimental)”.

sorata · December 16, 2024, 8:47pm

Yes, it’ll be nice if someone else looks into this and sends a PR. Jarrett might have too much on his plate.

sorata · December 16, 2024, 9:22pm

Reason for merging different posts? @Danika_Dakika

Danika_Dakika · December 16, 2024, 9:24pm

I merged these topics – whether the graph is wrong or the tooltip is wrong or both are wrong is all closely related.

sorata · December 16, 2024, 9:26pm

I wasn’t reporting anything being wrong. The tooltip was just showing a previous data-point. Well, anyways. I thought it’s a more visual bug than anything.

Danika_Dakika · December 16, 2024, 9:39pm

If the graph and the tooltip don’t match – doesn’t one of them have to be wrong?

Expertium · December 16, 2024, 11:06pm

Relevant: Fix Fsrs simulator input problems by Luc-Mcgrady · Pull Request #3642 · ankitects/anki · GitHub

A_Blokee · December 17, 2024, 12:35am

That PR doesnt touch the graph data itself, just the surrounding inputs.

L.M.Sherlock · December 17, 2024, 7:02am

I guess the focus line doesn’t match the data points well:

github.com

ankitects/anki/blob/a0712b04e1e251ac075edd5afea7c91b34b5f28c/ts/routes/graphs/simulator.ts#L151-L178


      
          function mousemove(event: MouseEvent, d: any): void {
              pointer(event, document.body);
              const date = x.invert(d[0]);
          
              const groupData: { [key: string]: number } = {};
          
              groups.forEach((groupPoints, key) => {
                  const bisect = bisector((d: number[]) => x.invert(d[0])).left;
                  const index = bisect(groupPoints, date);
                  const dataPoint = groupPoints[index - 1] || groupPoints[index];
          
                  if (dataPoint) {
                      groupData[key] = y.invert(dataPoint[1]);
                  }
              });
          
              focusLine.attr("x1", d[0]).attr("x2", d[0]).style("opacity", 1);
          
              const days = +((date.getTime() - Date.now()) / (60 * 60 * 24 * 1000)).toFixed();
              let tooltipContent = `Date: ${localizedDate(date)}<br>In ${days} Days<br>`;

This file has been truncated. show original

Perhaps it’s caused by moving average:

github.com

ankitects/anki/blob/a0712b04e1e251ac075edd5afea7c91b34b5f28c/ts/routes/deck-options/FsrsOptions.svelte#L302-L314


      
          function movingAverage(y: number[], windowSize: number): number[] {
              const result: number[] = [];
              for (let i = 0; i < y.length; i++) {
                  let sum = 0;
                  let count = 0;
                  for (let j = Math.max(0, i - windowSize + 1); j <= i; j++) {
                      sum += y[j];
                      count++;
                  }
                  result.push(sum / count);
              }
              return result;
          }

The current window size is daysToSimulate / 50.

L.M.Sherlock · December 17, 2024, 7:45am

The #1 will be fixed in Fix/dataPoint index is off by one day in simulator by L-M-Sherlock · Pull Request #3645 · ankitects/anki · GitHub

Topic		Replies	Views
[BUG]: Simulator Tooltip Shows Wrong Data FSRS	2	10	December 16, 2024
[Suggestion] Don't Show Data for Hidden Line on Tooltip FSRS	4	22	December 21, 2024
Anki simulator and FSRS Scheduling	1	552	July 6, 2023
Can someone help me interpret the results from Anki Simulator? Add-ons	0	462	August 1, 2022
[Suggestion]: Have Average Review Stat for Each Sim FSRS	2	14	December 21, 2024

The FSRS Simulator graph & tooltips are wrong

1. The number of reviews in the tooltips seem to be off by one day

2. The number of reviews tomorrow is sometimes significantly less than it should be.

Steps

Behaviour

Related topics