FYI: I was hoping someone here could figure out where the svg icon is stored. I still can not figure it out so the only change I did was swapping the pin and html buttons:
main ← GithubAnon0000:patch-1
opened 10:37PM - 15 Feb 25 UTC
Fixes: https://forums.ankiweb.net/t/if-the-user-completely-erases-a-sticky-field… -that-should-automatically-unstickify-it/38177/16?u=anon_0000
@dae wanted to see the swapped icons in situ, so here's a PR.
The goal from OP was to reduce accidental misclicks on the pin icon when the user actually wanted to scroll. This lead to confused users a couple of times that thought that anki was somehow suddenly broken.
The proposed icon change isn't implemented here as I do not understand where the icon is generated from. I can open a follow-up PR if somehow can help me with finding the old icon / where the new icon would have to go to.
llama
February 16, 2025, 4:46am
23
putting it in same place as contain-plus.svg should be fine
1 Like
Thanks @llama !
I opened a follow up PR that (if merged) will close this suggestion:
main ← GithubAnon0000:sticky-icon
opened 01:32PM - 16 Feb 25 UTC
This is a follow-up on #3821.
Fixes: https://forums.ankiweb.net/t/if-the-user… -completely-erases-a-sticky-field-that-should-automatically-unstickify-it/38177/16?u=anon_0000.
# Changes made
I took the icons from @sprvlcn here: https://forums.ankiweb.net/t/if-the-user-completely-erases-a-sticky-field-that-should-automatically-unstickify-it/38177/14?u=anon_0000.
ts/lib/icons/contain-plus.svg is on one single line, which is why I put the new icon code in one line too.
The hollow icon was hardly readable though by default, which is why I changed the fill to currentColor.
# Pictues
The first field is checked / active / sticky, the second one is not checked / is inactive / is not sticky.
## This is what it currently looks like in main.
### Light
### Dark
## This is what it would look like with this PR without changing the pin fill.
### Light
### Dark
## This is what it looks like with this PR if this PR would be merged now (changed pin fill).
### Light
### Dark
# Others
This needs approval from @dae who wanted to see the change in situ.
1 Like