The names in CONTRIBUTING and qt/aqt/about.py do not match (about doesn’t show a lot of contributers).
I’m guessing this is not intended. It should be fairly easy to parse the CONTRIBUTERS file and automatically populate those names into allusers in about.py using something like bash (and probably even python).
What do you think?
1 Like
I decided to create a python script that generates the names:
ankitects:main ← GithubAnon0000:generate_contributors_list
opened 05:49PM - 19 Jan 25 UTC
https://forums.ankiweb.net/t/names-in-about-window-do-not-match-names-in-contrib… uting/54570?u=anon_0000
This python script automatically parses the CONTRIBUTORS file and formats it, so that about.py can use it.
about.py now includes about_contributors.py, which was generated by that python script.
_Note:_
1. There are a lot of print functions commented out which I used while developing. Didn't know whether I should remove those.
2. Pycharm only shows 4 "typos" for the word "allusers". No other warnings, erros, ect.
3. I cannot test `./ninja check` with the latest main, since it refuses to build for me (I used the branch from current stable as a base). I also cannot run in with the stable branch, since my vm has less than 50mb space left. If github doesn't auto check it, I'll do so once I increase my vms disk capacity.
4. Linting is probably wrong, but no idea how to lint according to `.pylintrc`.
5. Maybe the copyright notice at the top is incorrect? Not sure if there's a certain style I must follow.
6. @sommerluk appears two times in the list of contributors (once with noreply email and once with another email). Should one of them be removed @sommerluk ?
I did build this with the current stable branch and checked that it works. So probably no issues with the beta either.
I have basically zero python experience, so any advice (see github) is welcomed!
Edit: Someone on github mentioned that something similar had been proposed (and closed) before. So I’ll close my PR too.
system
February 18, 2025, 5:56pm
3
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.