Anki 2.1.55 Beta 3+

Looks like setting flex-direction: column on .row fixes this. I have no idea why this is only an issue with some rows.

This patch fixes it anyway (not sure if it’s the right solution):

diff --git a/ts/deck-options/HelpSection.svelte b/ts/deck-options/HelpSection.svelte
index 47ff91c9e..fa967c30d 100644
--- a/ts/deck-options/HelpSection.svelte
+++ b/ts/deck-options/HelpSection.svelte
@@ -20,6 +20,8 @@
             {@html section.title}
         {/if}
     </h2>
+</Row>
+<Row>
     {#if section.help}
         {@html marked(section.help)}
     {:else}

Hi,

Add-ons box in the deck options cannot be translated:

In the hint window in the deck options, the reference to the manual cannot be translated:
image

1 Like

This one should actually be translatable. I added a new .ftl file called “help”. Perhaps this isn’t reflected in the online translation service yet, @dae?

Apparent height difference

The buttons all have the same height, but disabled ones do not have a box-shadow.

no box-shadow on disabled buttons

box-shadow for all buttons

Notice that it’s much more difficult to spot which buttons are clickable? I’m open for alternatives, but I think a box-shadow for everything would make disabled buttons look too clicky.

QPushButton not matching webview button

Re 2: The Type and Deck buttons are QPushButtons (= Qt Widgets) and are not part of the webview.

I gave these widgets custom styles for Windows/Linux that recreate the look of the web counterparts, but for macOS we’ll keep the native styles, because they’re a bit more polished. I’ll implement separate webview styles for macOS to make all buttons look the same.

This beta was released a bit too early for that, though. Reason was to get some feedback over the weekend.

Thank you for that observation. Given the alternatives, I still prefer uniform shadow. For one thing, the shadow hints at the real-world appearance of a button sticking up from its surface, which would be the case whether activated or deactivated. Since we are used to “grayed out” as an indicator for deactivated, I suggest a little more aggressive (that is, lighter) gray. Another alternative to try might be to slightly darken the background of the deactivated buttons. Then the whole button would be “grayed out,” as the total contrast between background and text would be further reduced as compared to the activated form.

Edit: would it also help to lighten the shadow while still giving it the same apparent size?

The elevation maps used for the box-shadow are a bit too big, even at the smallest level (1). Lightening the shadow would be an option, but it would still look a bit rough.

I made an alternative with #2159, where buttons are flat on all platforms and only get a slight gradient on hover for Win/Lin. The bottom border is slightly darker than the top, making for an ever-so-slight elevation effect without the need for a box-shadow.

Here’s a sample:

Field focused

image

No field focused

image

That looks better. Even the active buttons look better in my opinion. It might have the added benefit that the difference on Mac between those buttons and the Type and Deck buttons will be far less obvious.

That was the main reason for the PR :slight_smile:

I had two choices:

  1. create separate webview styles for macOS (cumbersome)
  2. revert the 3d effect for Win/Lin and adjust the webview buttons for all platforms

I went for 2. IMO styles should be the same across all platforms and this is a step towards that goal.

A couple of observations about GUI:

2.1.55:

I think the old behaviour was better and clearer, specially for new users who may not know what “Show duplicates” actually mean.

  • In 2.1.54 when you clicked in an up-down control and keep the moused pressed, this is what happens:
    1

However, this standard behaviour is not possible anymore with 2.1.55 (nothing serious, but probably not what most users would expect)
2

2 Likes

This was accidental and will be fixed with Add back thick field focus border by kleinerpirat · Pull Request #2160 · ankitects/anki · GitHub.

The border changes color to red for duplicates.

1 Like

I’m sure we can add this behavior in the near future (Edit: added :white_check_mark:), but as you said, it’s not the highest priority right now. For now, the mousewheel mechanic I implemented should be a sufficient replacement. If you didn’t notice yet, if you hover a focused spinbox you can increment/decrement the value by scrolling.

2 Likes

Using no shadows on disabled buttons makes it much clearer which are disabled. I’d leave it as-is.

I’m having trouble reproducing this. Changing presets seems to work for me… Did I understand correctly that it’s about updating from 2.1.54 to 2.1.55?

Maybe you could provide a simple test case to illustrate the issue?

On my 1920x1080 screen, 16px seems a bit small for my taste:

But my vision is not the greatest, so I understand how others probably perceive the UI size differently. Also, there are platform differences in font-size:

Maybe it’s time to unify these values?


Windows users: How do you feel about the UI size (e.g. editor buttons)?

  • Default UI size is currently too big
  • Default UI size is currently too small
  • Default UI size is currently just right
0 voters

Linux users: How do you feel about the UI size?

  • Default UI size is currently too big
  • Default UI size is currently too small
  • Default UI size is currently just right
0 voters

Mac users: How do you feel about the UI size?

  • Default UI size is currently too big
  • Default UI size is currently too small
  • Default UI size is currently just right
0 voters

I compiled until the 0770290765106bc7c9679e094c53193b1a8e790b commit and the answer buttons appear this way. Don’t know if it is fixed in following pull requests.

btw my User Interface Size is 125%

I just tested this on current main with UI scale 125% and it seems to be fixed. If it still happens in the next beta, please ping me :slight_smile:

1 Like

The rest of the Anki UI is actually a bit small to me by default (I’m also on Windows). It’s just the font of the field names that feels disproportionately large when compared to other elements, in my opinion. But all in all it’s not a huge issue and definitely something I can live with!

1 Like

Take this deck for example:

Enhance main window:


Deck options screen 2.1.55 beta:

Deck options screen in 2.1.54:
imagen

I didn’t switch the preset, the change is made by simply starting the other Anki version.

Here the deck is uploaded as .colpkg, so that hopefully you can reproduce it.

1 Like

I’m also having problems with presets. In some cases the daily limits are simply ignored. Also, after changing parameters > Save, it doesn’t save correctly.
Custom Study > Increase today’s news / review limits is also ignored (EDIT: It’s also ignored in 2.1.54 with the same deck, so I’m not sure if this an user error…)

An example:
2
As you can see:
A) Deck options for A2 deck:

  • Preset: 10
  • This deck: 10
  • Today only: 20

New cards should be 20 (today only), but it’s actually 120

B) If you change the deck options to:

  • Preset: 10
  • This deck: 20
  • Today only: 30
    New cards should now be 30, but it’s still 120

C) If you click in Options again the parameters were’nt saved correctly:

  • Preset: 10
  • This deck: 30
  • Today only: 30
2 Likes

I finally got around to spending a couple hours testing things against my full addon collection. Overall I really like the style changes. Thanks to everyone involved! (@kleinerpirat)

  1. Is there a way to go back to the old appearance and button style @dae ? Previously I would use the instructions here but that doesn’t work anymore
    2.1.55Qt6


    2.1.54Qt5

  2. I too am having the issue with the flags changing to black on nightmode when I try to rename them

  3. Addons that broke or partially broke (details here):

  • Customize background and gear icon
  • Recolor
  • Fastbar (a bug on one profile that I couldn’t figure out but fine otherwise
  • Field AutoComplete
  • Speed focus mode
  • a few of my beta addons including “Skip weekends and holidays” and “pdf exporter”
  • AnkiHub

Overall not as bad as expected (@kleinerpirat your cautious optimism was correct)

1 Like